-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run core tests on Windows and test run stability #464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/test.yml
mtmk
changed the title
Run core tests on windows
Run core tests on Windows and test run stability
Sep 24, 2024
Reorganized solution items for better project structure, moving miscellaneous files to a general grouping and creating dedicated sections for GitHub workflows and scripts. This improves clarity and maintainability of the project.
Introduced a base NATS server fixture for test classes and updated test cases to utilize the fixture. This simplifies server management and ensures consistent URL handling. Also, enhanced tests to use unique prefixes for identifiers to improve reliability.
MauriceVanVeen
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mtmk
added a commit
that referenced
this pull request
Oct 1, 2024
Merged
mtmk
added a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some of the core test reliability issues and improving test coverage on Windows. Because test
NatsServer
seems to be a little heavy, chopped up theCore
tests intoCore2
andCoreUnit
tests.Core2
is now using a lighter test NATS server process andCoreUnit
doesn't have any need for running the server.Also, fixed a few build warnings mainly around package security warnings for utility projects (not the public libraries); organized solution files.